chore(book): add simple calculator example #439
Conversation
There was a problem hiding this comment.
Hello @your-diary, it looks amazing! I don't have much to say, except a few rephrasing suggestions. The English looked very good, but I am myself not a native speaker.
You may note that I pushed a fix to another book page, as I just noticed it when reviewing yours, and I didn't want to create one PR just for that ^^'.
There was a problem hiding this comment.
Did you make those image, or did you take them from somewhere else on the internet?
I think it is important to mention this, and include appropriate licensing information.
There was a problem hiding this comment.
I created the images on my own, using Google Slides.
I'm ok to contribute the images under the same license as Logos' (MIT and Apache 2.0).
There was a problem hiding this comment.
Perfect! If you want, please add some header at the top of the page (just after the title) mentioned this work (and images) were contributed by you. If you don't want, then that's ok for me.
There was a problem hiding this comment.
Thank you for your suggestion!
Added in e084cb2.
|
@jeertmans I accepted most of the suggestions and replied to some of your comments. |
|
Thank you @your-diary! |
* chore(book): add simple calculator example * fix(book): footnote * Apply suggestions from code review Co-authored-by: Jérome Eertmans <[email protected]> * Partially apply a suggestion from code review * fix(book): add clone instructions to the simple calculator example * chore(book): add the contributor info to the simple calculator example --------- Co-authored-by: ynn <[email protected]> Co-authored-by: Jérome Eertmans <[email protected]>
* Minor readme improvments (#442) * chore: move the release process to its own file * chore: remove extra whitespace in rust code block * chore: better with a title :) ! * chore(book): add simple calculator example (#439) * chore(book): add simple calculator example * fix(book): footnote * Apply suggestions from code review Co-authored-by: Jérome Eertmans <[email protected]> * Partially apply a suggestion from code review * fix(book): add clone instructions to the simple calculator example * chore(book): add the contributor info to the simple calculator example --------- Co-authored-by: ynn <[email protected]> Co-authored-by: Jérome Eertmans <[email protected]> * chore(release): bump version * chore(release): replace version in docs * chore(lint): apply Clippy and Rustfmt * chore(lint): allow needless lifetime --------- Co-authored-by: tk <[email protected]> Co-authored-by: ynn <[email protected]> Co-authored-by: ynn <[email protected]>
Related: #436
This PR adds a simple calculator example, which demonstrates how
logoscrate can be combined with a parser generator library to implement an interpreter for a DSL or a programimng language.I also added a page to the book.
As I'm not a native English speaker, feel free to edit the language in the book.