Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax error bound #459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SarguelUnda
Copy link

This relax the bound on logos Error type for more interoperability with error library like anyhow. I could not see where or if those bounds were mandatory. We still need the default trait for constructor but it is ok to use a manual implementation over a wrapper type like

struct MyAppLexError(anyhow::Error)

It would be harder/misleading to do so for Clone and PartialEq hence the pull request.

@jeertmans
Copy link
Collaborator

Hi @SarguelUnda, thanks for your PR!

As you can see, your changes require a increase of the minimal supported Ruest version (MSRV): do you have any idea what is causing this? I guess you can fiund the explaination in the changelog of Rust 1.81? Or maybe is was already broken before, as it seems to be triggered by a dependency we have.

@SarguelUnda
Copy link
Author

Hello,

from running the command locally it seems to be the home deps from the afl package from the fuzz local crate that trigger this error.

cargo msrv verify -- cargo check --workspace --features debug:

Compatibility Check #1: Rust 1.74.0
  [FAIL]   Is incompatible

  ╭───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │ error: package `home v0.5.11` cannot be built because it requires rustc 1.81 or newer, while the currently active rustc version is 1.74.0 │
  │ Either upgrade to rustc 1.81 or newer, or use                                                                                             │
  │ cargo update [email protected] --precise ver                                                                                                    │
  │ where `ver` is the latest version of `home` supporting rustc 1.74.0                                                                       │
  │                                                                                                                                           │
  ╰───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

cargo tree --workspace

logos-fuzz v0.15.0
├── afl v0.15.13
│   ├── libc v0.2.169
│   ├── rustc_version v0.4.1 (*)
│   └── xdg v2.5.2
│   [build-dependencies]
│   └── home v0.5.11
│       └── windows-sys v0.59.0
│           └── windows-targets v0.52.6 (*)
├── arbitrary v1.4.1
└── logos-codegen v0.15.0 (*)

@sokorototo
Copy link

This somewhat tracks, as an error type really only needs Debug and Display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants