test: fix tests to conform to new validations

macite · Jul 26, 2024 · 527b810 · 527b810
1 parent edcd36a
commit 527b810
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 15 deletions.
diff --git a/test/api/tii/tii_action_api_test.rb b/test/api/tii/tii_action_api_test.rb
@@ -21,15 +21,20 @@ def app
     # Create a task definition with two attachments
     @unit = FactoryBot.create(:unit, with_students: false, task_count: 0)
 
-    @task_def = FactoryBot.create(:task_definition, unit: @unit, upload_requirements: [
-      {
-        'key' => 'file0',
-        'name' => 'My document',
-        'type' => 'document',
-        'tii_check' => 'true',
-        'tii_pct' => '10'
-      }
-    ])
+    @task_def = FactoryBot.create(
+      :task_definition,
+      unit: @unit,
+      upload_requirements:
+        [
+          {
+            'key' => 'file0',
+            'name' => 'My document',
+            'type' => 'document',
+            'tii_check' => true,
+            'tii_pct' => 10
+          }
+        ]
+    )
 
     ga1 = TiiGroupAttachment.create(
       task_definition: @task_def,

diff --git a/test/models/task_test.rb b/test/models/task_test.rb
@@ -10,7 +10,7 @@ class TaskDefinitionTest < ActiveSupport::TestCase
   include TestHelpers::AuthHelper
   include TestHelpers::JsonHelper
 
-  def error! msg
+  def error! msg, code
     raise msg
   end
 

diff --git a/test/sidekiq/tii_check_progress_job_test.rb b/test/sidekiq/tii_check_progress_job_test.rb
@@ -17,8 +17,8 @@ def test_check_eula_change
         'key' => 'file0',
         'name' => 'My document',
         'type' => 'document',
-        'tii_check' => 'true',
-        'tii_pct' => '10'
+        'tii_check' => true,
+        'tii_pct' => 10
       }
     ])
 
@@ -150,8 +150,8 @@ def test_that_progress_checks_eula_change
         'key' => 'file0',
         'name' => 'My document',
         'type' => 'document',
-        'tii_check' => 'true',
-        'tii_pct' => '10'
+        'tii_check' => true,
+        'tii_pct' => 10
       }
     ])
 

diff --git a/test/sidekiq/tii_webhooks_job_test.rb b/test/sidekiq/tii_webhooks_job_test.rb
@@ -39,7 +39,7 @@ def test_register_webhooks
                              .with(tii_headers)
                              .with(
                                body: TCAClient::WebhookWithSecret.new(
-                                 signing_secret: Base64.encode64(ENV.fetch('TCA_SIGNING_KEY', nil)),
+                                 signing_secret: Base64.encode64(ENV.fetch('TCA_SIGNING_KEY', nil)).tr("\n", '' ),
                                  url: TurnItIn.webhook_url,
                                  event_types: [
                                    'SIMILARITY_COMPLETE',