Declare the miniaudio submodule as shallow #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a repo includes dr_libs as a submodule, a recursive clone would also pull miniaudio with its full history, which currently takes up 157.5 MiB on disk. Declaring miniaudio as shallow would reduce this to 7.4 MiB by only downloading any data needed for the recorded commit. This seems to be a better default for consumers who most likely won't need to jump around in miniaudio's history, if they even build the tests at all. This won't affect existing checkouts, and even new ones can later add back the history via `git fetch --unshallow`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a repo includes dr_libs as a submodule, a recursive clone would also pull miniaudio with its full history, which currently takes up 157.5 MiB on disk. Declaring miniaudio as shallow would reduce this to 7.4 MiB by only downloading any data needed for the recorded commit. This seems to be a better default for consumers who most likely won't need to jump around in miniaudio's history, if they even build the tests at all. This won't affect existing checkouts, and even new ones can later add back the history via
git fetch --unshallow.