x264: update to 0.164.3108

[mohd-akram]

Description

Closes: https://trac.macports.org/ticket/62079

Tested on

macOS 15.3.1 24D70 arm64
Xcode 16.2 16C5032a

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@mascguy for port ffmpeg-devel, ffmpeg, ffmpeg4, ffmpeg6, ffmpeg7.
@dbevans for port ffmpeg, transcode, x264.
@jeremyhu for port ffmpeg, libquicktime-devel.
@ctreleaven for port mythtv.27, mythtv.28.
@Liontooth for port transcode.
@barracuda156 for port VLC2, ffmpeg7.

[barracuda156]

It does not touch any non-powerpc code, why not keep it unconditionally?

[mohd-akram]

It changes the version string. It's also specific to Apple PPC not PPC generally.

[barracuda156]

I do not think that the code compliant with ISA 2.02 won’t compile or execute on the current POWER arch. VSX is an extension, it can be disabled when compiling for VSX-capable CPUs (GCC has -mno-vsx flag for that).

It is also not Apple-specific, at least from the comment in the portfile. Both Linux and *BSD support Power arch without VSX insns support.

[mohd-akram]

Presumably the performance will be worse? It seems this issue has been reported upstream and there's a simpler patch there.

[mohd-akram]

@barracuda156 or @kencu Can you try the updated patch (based on this comment) on PPC?

[barracuda156]

I certainly can test, but only in about a week, I got no access to my hardware until then. From comments it seems that verifying the build is not sufficient, we also need to test encoding/decoding.
Hopefully someone of Gentoo people verified that, but from the patch itself it is not clear whether something actually defines WORDS_BIGENDIAN on a BE platform (it is not a standard macro defined by the compiler, AFAIR).