Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Madara Compatibility #12

Closed
wants to merge 8 commits into from
Closed

Feat: Madara Compatibility #12

wants to merge 8 commits into from

Conversation

Mohiiit
Copy link
Contributor

@Mohiiit Mohiiit commented Oct 9, 2024

  1. starknet rs version bump
  2. for declaring legacy, using the same types created in the madara

ocdbytes
ocdbytes reviewed Oct 11, 2024
View reviewed changes
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. After starknet contract update let's test the test bridge function and then we can merge it.

antiyro
antiyro approved these changes Oct 11, 2024
View reviewed changes
src/main.rs
@@ -108,6 +111,7 @@ pub async fn bootstrap(config: &CliArgs) -> DeployBridgeOutput {
)
.unwrap();
log::info!("✅ Core setup init for L1 successful.");
sleep(Duration::from_secs(60)).await;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this sleep for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually madara needs a l1 core contract while starting, so I run bootstraper first, get the core contract, add it to madara code, run madara, meanwhile bootstraper is sleeping

I know this is not ideal and we have to think about how to improve the devX here

@Mohiiit Mohiiit closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocdbytes ocdbytes ocdbytes left review comments

@antiyro antiyro antiyro approved these changes

@apoorvsadana apoorvsadana Awaiting requested review from apoorvsadana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mohiiit @ocdbytes @antiyro