Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/clap #179

Merged
merged 66 commits into from
Nov 20, 2024
Merged

Feature/clap #179

merged 66 commits into from
Nov 20, 2024

Conversation

heemankv
Copy link
Contributor

@heemankv heemankv commented Nov 6, 2024

No description provided.

@heemankv heemankv self-assigned this Nov 6, 2024
apoorvsadana
apoorvsadana reviewed Nov 12, 2024
View reviewed changes
.env.example Show resolved Hide resolved
crates/da-clients/ethereum/src/lib.rs Outdated Show resolved Hide resolved
crates/da-clients/ethereum/src/lib.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/alerts/aws_sns/mod.rs Show resolved Hide resolved
crates/orchestrator/src/alerts/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cron/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/main.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/queue/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/queue/sqs/mod.rs Show resolved Hide resolved
crates/orchestrator/src/tests/config.rs Show resolved Hide resolved
apoorvsadana
apoorvsadana reviewed Nov 12, 2024
View reviewed changes
crates/orchestrator/src/workers/snos.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/workers/snos.rs Outdated Show resolved Hide resolved
crates/prover-services/gps-fact-checker/src/lib.rs Outdated Show resolved Hide resolved
crates/settlement-clients/starknet/src/lib.rs Outdated Show resolved Hide resolved
crates/utils/Cargo.toml Outdated Show resolved Hide resolved
e2e-tests/Cargo.toml Outdated Show resolved Hide resolved
e2e-tests/src/node.rs Outdated Show resolved Hide resolved
e2e-tests/src/node.rs Outdated Show resolved Hide resolved
e2e-tests/tests.rs Outdated Show resolved Hide resolved
e2e-tests/tests.rs Outdated Show resolved Hide resolved
@heemankv heemankv mentioned this pull request Nov 12, 2024
Open
apoorvsadana
apoorvsadana reviewed Nov 14, 2024
View reviewed changes
e2e-tests/src/node.rs Show resolved Hide resolved
crates/orchestrator/src/main.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/config.rs Show resolved Hide resolved
ocdbytes
ocdbytes reviewed Nov 16, 2024
View reviewed changes
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments. apart from these everything looks good.

crates/da-clients/ethereum/src/lib.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cli/cron/event_bridge.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cli/cron/event_bridge.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cli/queue/aws_sqs.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/config.rs Show resolved Hide resolved
crates/orchestrator/src/cli/storage/aws_s3.rs Show resolved Hide resolved
crates/orchestrator/src/setup/mod.rs Show resolved Hide resolved
crates/prover-services/sharp-service/tests/lib.rs Show resolved Hide resolved
crates/settlement-clients/starknet/Cargo.toml Outdated Show resolved Hide resolved
Mohiiit
Mohiiit reviewed Nov 19, 2024
View reviewed changes
crates/orchestrator/src/alerts/aws_sns/mod.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cli/alert/aws_sns.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/cli/cron/event_bridge.rs Show resolved Hide resolved
crates/orchestrator/src/cli/cron/mod.rs Show resolved Hide resolved
crates/orchestrator/src/cli/da/mod.rs Show resolved Hide resolved
crates/orchestrator/src/telemetry.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/tests/common/mod.rs Show resolved Hide resolved
crates/orchestrator/src/tests/common/mod.rs Show resolved Hide resolved
crates/orchestrator/src/workers/snos.rs Outdated Show resolved Hide resolved
crates/prover-services/gps-fact-checker/src/lib.rs Outdated Show resolved Hide resolved
apoorvsadana
apoorvsadana reviewed Nov 19, 2024
View reviewed changes
crates/orchestrator/src/cli/mod.rs Show resolved Hide resolved
crates/orchestrator/src/cli/storage/aws_s3.rs Outdated Show resolved Hide resolved
crates/orchestrator/src/setup/mod.rs Outdated Show resolved Hide resolved
@Mohiiit Mohiiit merged commit 58cca2c into main Nov 20, 2024
9 checks passed
@Mohiiit Mohiiit mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana approved these changes

@ocdbytes ocdbytes ocdbytes left review comments

@Mohiiit Mohiiit Mohiiit approved these changes

Assignees

@heemankv heemankv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heemankv @coveralls @Mohiiit @ocdbytes @apoorvsadana