Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"YouTube" is not a namespace #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zanderwar
Copy link

@zanderwar zanderwar commented Oct 31, 2017

While it is a namespace and should be new \Madcoda\YouTube\YouTube() as per PSR-4, it is in fact just new \Madcoda\YouTube()

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #63 into master will decrease coverage by 3.84%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage      88.7%   84.86%   -3.85%     
  Complexity       84       84              
============================================
  Files             5        5              
  Lines           248      304      +56     
============================================
+ Hits            220      258      +38     
- Misses           28       46      +18
Impacted Files Coverage Δ Complexity Δ
src/Youtube.php 96.62% <0%> (-0.72%) 75% <0%> (ø)
src/Facades/Youtube.php 0% <0%> (ø) 1% <0%> (ø) ⬇️
src/YoutubeServiceProviderLaravel5.php 0% <0%> (ø) 4% <0%> (ø) ⬇️
src/config/youtube.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
src/YoutubeServiceProviderLaravel4.php 0% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ceca5...77af091. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants