Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVideoInfo with params and Youtube quotas calculator #71

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tyteck
Copy link

@tyteck tyteck commented Dec 1, 2019

Hi
My first move was to add optionnal params to getVideoInfo and create one tests to go with.
My second move was to add Youtube quota calculation. The goal of this is to calculate the quota used on each api request made dynamically.

A class YoutubeQuotas has been made for it. And I inject a YoutubeQuotas instance in your Youtube class. If this object is set I'm calculating the quota used by the query.

If you have any question, please tell me :)
Thanks you for making this lib (I'm using it everyday) and for reading this :)
Cheers

@vesper8
Copy link

vesper8 commented Sep 23, 2020

excellent additions @tyteck ! I've copied your improvements to my fork

@madcoda would be great if you could add these changes as well

@tyteck could you possibly add a short code snippet example of how to best make use of this new quota functionality you've baked in?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants