Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign gem #29

Merged
merged 19 commits into from
Jan 12, 2015
Merged

Redesign gem #29

merged 19 commits into from
Jan 12, 2015

Conversation

ninjabiscuit
Copy link
Contributor

Updated all the things (mostly, implemented everything we did on dotcom):

  • Renamed gem sir_trevor_rails (used to be sir-trevor-rails)
  • Removed sir trevor JS and all its dependencies (should install files manually or from bower from now on)
  • Removed all the view helpers appart from sir_trevor_markdown (render_sir_trevor, render_sir_trevor_block, render_sir_trevor_image, sir_trevor_image_tag, parse_sir_trevor are all gone)
  • Removed the form helper (no more sir_trevor_text_area)
  • Added has_sir_trevor_content.rb as a concern for models with ST content
  • Remove jQuery rails dependency
  • Use view resolvers and to_partial_path to render ST content (instead of the view helper)
  • Add block array class
  • Add block classes
  • Add lookup methods on the block array

Take a look at the updated readme file for more info

There are no tests for this yet (:trollface:) but people are having problems with the old gem and this addresses most (all) of those issues.

...so... maybe we should just release it? Unless anyone has time to write the tests soon?

@Fudoshiki
Copy link

$ rails g sir_trevor_rails:views
DL is deprecated, please use Fiddle
c:/Ruby212-x64/lib/ruby/gems/2.1.0/bundler/gems/sir-trevor-rails-e1c7de50443a/li
b/sir_trevor_rails/view_resolver.rb:2:in `module:SirTrevorRails': uninitialize
d constant ActionView::FileSystemResolver (NameError)

@hayesr
Copy link

hayesr commented Jun 17, 2014

If anyone is interested, I recently implemented this branch in a toy CMS built on Rails 4.1. You can see it here: https://github.com/hayesr/clonepress/tree/trevor

I think I had to deviate a few times from the Readme instructions. If I get a chance I will submit a PR.

@hayesr
Copy link

hayesr commented Jun 18, 2014

I forgot to mention that this small change appears to be needed for Rails 4.1 compat.

@ninjabiscuit ninjabiscuit merged commit e1c7de5 into master Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants