Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SirTrevorRails::ViewResolver to be compatible with Rails 4.2.5.1 #49

Closed
wants to merge 1 commit into from

Conversation

cbeer
Copy link
Contributor

@cbeer cbeer commented Jan 25, 2016

Rails 4.2.5.1 added a fifth argument to #find_templates. Since we don't particularly care what the arguments are, we can just pass them through.

@dwb
Copy link
Contributor

dwb commented Jan 26, 2016

Sorry, didn't see this one and did it myself 😶
Thanks though!

@dwb dwb closed this Jan 26, 2016
@cbeer cbeer deleted the rails4251-compat branch January 26, 2016 16:04
@cbeer
Copy link
Contributor Author

cbeer commented Jan 27, 2016

Thanks, not a problem. Could we get a new release of the gem with this change?

@dwb
Copy link
Contributor

dwb commented Jan 28, 2016

We decided to release 0.5.0. I’ve just pushed it, so should be available any minute.

On 27 Jan 2016, at 23:46, Chris Beer [email protected] wrote:

Thanks, not a problem. Could we get a new release of the gem with this change?


Reply to this email directly or view it on GitHub #49 (comment).

Made by Many Limited is registered in England and Wales (No.06346338).
Registered office: Diespeker Wharf, 38 Graham Street, London, N1 8JX, UK

Made by Many Inc is registered in the State of New York (No.4427021). 65
Greene Street, 4th Floor, New York, NY 10012, USA

@cbeer
Copy link
Contributor Author

cbeer commented Jan 28, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants