This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Update README.md #12
Open
Update README.md #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrote an example that is an actual controller, using proper Laravel4 techniques
Added example that implements the database.
|
I just updated my first example to now include database implementation. |
|
Please make sure you follow PSR-2. |
|
|
||
| $name = explode(' ', $user['name']); | ||
| $email = $user['email']; | ||
| $user = User::whereRaw('first_name = ? and last_name = ? and email = ?', [$name[0], end($name), $email]); |
There was a problem hiding this comment.
This looks kind of weird no ? Why not use the query builder ?
|
That was just left over from the way I did it. On my platform you're redirected to a different place if you are registering vs. logging in. However there is no reason it can't be firstOrCreate. As far as using the query builder, the way I did it was just personal preference. I don't really like multi-line functions, or really long lines. So that was purely just preference. You could change both of those things, but it doesn't really change the flow that much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote an example that is an actual controller, using proper Laravel4 techniques.
Just expounded upon the previous example since I had to change it a fair bit for Laravel 4 standards