Skip to content

Commit

Permalink
[x] user stories
Browse files Browse the repository at this point in the history
  • Loading branch information
madmatvey committed May 17, 2024
1 parent 57a8c93 commit 1aa2aff
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ jobs:
env:
MYSQL_DATABASE: 'homework_assignment_2024_test'
MYSQL_USER: 'rails_user'
MYSQL_PASSWORD: 'password'
MYSQL_ROOT_PASSWORD: 'password'
MYSQL_PASSWORD: ${{ secrets.MYSQL_PASSWORD }}
MYSQL_ROOT_PASSWORD: ${{ secrets.MYSQL_ROOT_PASSWORD }}
MYSQL_ROOT_HOST: '%'
MYSQL_TCP_PORT: 3307
# MYSQL_HOST: localhost
Expand All @@ -26,9 +26,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v1
- name: Show databases for root user
run: mysql --protocol=tcp -h 127.0.0.1 -P 3307 -u root -ppassword -e "SHOW DATABASES"
run: mysql --protocol=tcp -h 127.0.0.1 -P 3307 -u root -p${{ secrets.MYSQL_ROOT_PASSWORD }} -e "SHOW DATABASES"
- name: Show databases for rails_user
run: mysql --protocol=tcp -h 127.0.0.1 -P 3307 -u rails_user -ppassword -e "SHOW DATABASES"
run: mysql --protocol=tcp -h 127.0.0.1 -P 3307 -u rails_user -p${{ secrets.MYSQL_PASSWORD }} -e "SHOW DATABASES"
- uses: actions/setup-node@v1
with:
node-version: 20.x
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ Your primary task with this homework assignment is to resolve the user stories b
*Estimated time to completion: 3-4 hours*

## User Stories
- [ ] The frontend is not properly fetching data, i.e. filters aren't being sent, requests are being sent too often, non-successful response codes aren't being handled, etc.
- [ ] The backend is taking too long to return the expected data, i.e. filters aren't being applied, too much data is being returned, db performance isn't optimized, etc.
- [ ] The confidence in our current functionality and ability to deploy additional changes is extremely low. Help us increase our confidence in an automated way.
- [ ] The confidence in our security posture is also very low. Help us increase our confidence that we are running a securely designed application.
- [x] The frontend is not properly fetching data, i.e. filters aren't being sent, requests are being sent too often, non-successful response codes aren't being handled, etc.
- [x] The backend is taking too long to return the expected data, i.e. filters aren't being applied, too much data is being returned, db performance isn't optimized, etc.
- [x] The confidence in our current functionality and ability to deploy additional changes is extremely low. Help us increase our confidence in an automated way.
- [x] The confidence in our security posture is also very low. Help us increase our confidence that we are running a securely designed application.

## Assumptions

Expand Down

0 comments on commit 1aa2aff

Please sign in to comment.