Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HTTP compression #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgisbert
Copy link

Just added the bits to enable HTTP compression, in case you might consider it is worthy :)

@madskristensen
Copy link
Owner

The output was already gzip'ed from other middleware. Did you not get your output compressed?

@sgisbert
Copy link
Author

Hi,

no, I'm afraid I'm not getting the content compressed.

This is the response headers I get with the original code on my homepage, with a size of 9,91 KB:

image

I didn't notice any Content-Encoding:gzip header, so I went for the compression bits, which give me the following headers:

image

Where the Brotli content encoding header appears, and now the transferred size is 3,65KB.

Maybe am I missing something? Which middleware is supposed to be gzipping the response?

Thanks!

@xaberue
Copy link

xaberue commented Aug 28, 2022

Since the projects seems a bit abandoned and I would like to recover and maintain, may I ask @sgisbert to replicate this PR into the current fork? I don't want to copy paste the different code enhancements proposed in the original repository.

If at the end of this upgrade @madskristensen wants to integrate in this original repository will be more than welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants