LESS (Fixed #346: source map path fixes & code refactoring) and Analysis (warning fixes) #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA fixes for:
LESS Source Maps:
First off, there are three kinds of URLs we are dealing with:
Unfortunately, there is no clear documentation and the SourceMap support in browsers is still unclear. For instance, by this thread less/less.js#1050, one can observe:
This fix (3a4950f) will devise all the paths from the compiled CSS file.
Since I haven't played with source maps much AND the information available online regarding this specific matter is quite insignificant which explicitly detail what kind of paths should we use. So I had to take inferences (from td.map, scss.map) and few assumptions.
Having said that, if someone is black-belt in SourceMaps and experiencing issues with Web essentials generated source maps' path, please explain the requirements and we shall fix it. Note that it will be a hassle to support absolute URLs in addition to relative URLs, but nonetheless, its definitely doable.