Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cfg in declare class! #286

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Handle cfg in declare class! #286

merged 5 commits into from
Nov 9, 2022

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Nov 9, 2022

Fixes #285.

cfg_attr is not yet handled, but that doesn't work properly in extern_methods either, so instead I've just documented that that's the case, and encouraged people to open an issue if they have a need for it.

@madsmtm madsmtm added bug Something isn't working A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Nov 9, 2022
@madsmtm
Copy link
Owner Author

madsmtm commented Nov 9, 2022

This also allows implementing a protocol or not based on a cfg

@madsmtm madsmtm force-pushed the cfg-in-declare-class branch from b5c4d36 to 31637a3 Compare November 9, 2022 21:30
@madsmtm madsmtm force-pushed the cfg-in-declare-class branch from 31637a3 to 0a7cd46 Compare November 9, 2022 21:35
@madsmtm madsmtm merged commit 26ec63e into master Nov 9, 2022
@madsmtm madsmtm deleted the cfg-in-declare-class branch November 9, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cfg in declare_class!
1 participant