chore: update PHP/Composer/Magento versions and defaults for actions #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge this until 2.4.7-p2 is tagged upstream and synced to our mirror repositories, due to the version references. |
fballiano
reviewed
Jan 7, 2025
| php-version: 8.1 | ||
| tools: composer:v2.4.2 | ||
| php-version: 8.3 | ||
| tools: composer:v2.7.7 |
There was a problem hiding this comment.
Suggested change
| tools: composer:v2.7.7 | |
| tools: composer:v2.8.4 |
fballiano
reviewed
Jan 7, 2025
|
|
||
| - uses: ./get-composer-version | ||
| id: composer-version | ||
|
|
||
|
|
||
| - name: Fail if versions do not match | ||
| if: steps.composer-version.outputs.version != '2.4.2' | ||
| if: steps.composer-version.outputs.version != '2.7.7' |
There was a problem hiding this comment.
Suggested change
| if: steps.composer-version.outputs.version != '2.7.7' | |
| if: steps.composer-version.outputs.version != '2.8.4' |
fballiano
reviewed
Jan 7, 2025
| php-version: 8.1 | ||
| tools: composer:v2.4.2 | ||
| php-version: 8.3 | ||
| tools: composer:v2.7.7 |
There was a problem hiding this comment.
Suggested change
| tools: composer:v2.7.7 | |
| tools: composer:v2.8.4 |
fballiano
reviewed
Jan 7, 2025
|
|
||
| - run: composer create-project --repository-url="https://mirror.mage-os.org" "magento/project-community-edition:2.4.5-p1" ../magento2 --no-install | ||
| - run: composer create-project --repository-url="https://mirror.mage-os.org" "magento/project-community-edition:2.4.7-p2" ../magento2 --no-install |
There was a problem hiding this comment.
Suggested change
| - run: composer create-project --repository-url="https://mirror.mage-os.org" "magento/project-community-edition:2.4.7-p2" ../magento2 --no-install | |
| - run: composer create-project --repository-url="https://mirror.mage-os.org" "magento/project-community-edition:2.4.7-p3" ../magento2 --no-install |
fballiano
reviewed
Jan 7, 2025
| tools: composer:v2 | ||
| mode: extension | ||
| magento_version: magento/project-community-edition:2.4.5-p1 | ||
| magento_version: magento/project-community-edition:2.4.7-p2 |
There was a problem hiding this comment.
Suggested change
| magento_version: magento/project-community-edition:2.4.7-p2 | |
| magento_version: magento/project-community-edition:2.4.7-p3 |
fballiano
reviewed
Jan 7, 2025
|
|
||
| - uses: mage-os/github-actions/cache-magento@main | ||
| with: | ||
| mode: 'extension' | ||
| composer_cache_key: 'magento/project-community-edition:2.4.5-p1' | ||
| composer_cache_key: 'magento/project-community-edition:2.4.7-p2' |
There was a problem hiding this comment.
Suggested change
| composer_cache_key: 'magento/project-community-edition:2.4.7-p2' | |
| composer_cache_key: 'magento/project-community-edition:2.4.7-p3' |
fballiano
reviewed
Jan 7, 2025
| @@ -69,7 +69,7 @@ runs: | |||
| - name: Check if allow-plugins option is available for this version of composer | |||
| uses: mage-os/github-actions/semver-compare@main | |||
| with: | |||
| version: 2.2 | |||
| version: 2.7 | |||
There was a problem hiding this comment.
Suggested change
| version: 2.7 | |
| version: 2.8 |
fballiano
reviewed
Jan 7, 2025
| tools: composer:v2 | ||
| mode: extension | ||
| magento_version: 2.4.5-p1 | ||
| magento_version: 2.4.7-p2 |
There was a problem hiding this comment.
Suggested change
| magento_version: 2.4.7-p2 | |
| magento_version: 2.4.7-p3 |
fballiano
reviewed
Jan 7, 2025
| @@ -27,7 +27,7 @@ inputs: | |||
|
|
|||
| magento_version: | |||
| required: false | |||
| default: '~2.4.5' | |||
| default: '~2.4.7-p2' | |||
There was a problem hiding this comment.
Suggested change
| default: '~2.4.7-p2' | |
| default: '~2.4.7-p3' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: Outdated versions of PHP/Composer/Magento referenced in actions
What is the new behavior?
This should bring everything up to date for latest releases.
Do not merge this until 2.4.7-p2 is tagged upstream and synced to our mirror repositories.
Does this PR introduce a breaking change?
Other information