VCL_recv rework based on closed Magento 2 PR #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a rework of the Magento VCL (the vcl_recv part) PR found here:
https://github.com/magento/magento2/pull/36796/files
I left out 2 controversial changes:
/customer
and/checkout
Main reason for this is that, as a hoster (and support on Varnish issues), I see a lot of extensions that accidently remove
cache disables. Without this part of the VCL, the result could be a disaster for merchants.
Though I understand the reasoning behind this (preventing cache variations), the same technique is used in the frontend.
I have seen this work perfectly for one of our clients, so I am hesitant to remove something that seemed to be working
PRs for other subroutines will follow (probably weekly)
All credits go to @peterjaap and @ThijsFeryn, I am simpling slicing this up and removing controversial parts to get early approval.
Related Pull Requests
https://github.com/magento/magento2/pull/36796/files
Manual testing scenarios
Contribution checklist (*)