9.2.5: #193

mage2pro · Jan 28, 2023 · b5e6930 · b5e6930
1 parent 1598642
commit b5e6930
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/Shipping/Plugin/Model/CarrierFactoryT.php b/Shipping/Plugin/Model/CarrierFactoryT.php
@@ -10,9 +10,14 @@ final class CarrierFactoryT {
 	 * It forces the @see \Df\Shipping\Method descendants to be singletons:
 	 * @see \Magento\Shipping\Model\CarrierFactory::create()
 	 * https://github.com/magento/magento2/blob/2.2.3/app/code/Magento/Shipping/Model/CarrierFactory.php#L57-L80
+	 * 2023-01-28
+	 * «Return value of Df\Shipping\Plugin\Model\CarrierFactoryT::aroundCreate()
+	 * must implement interface Magento\Shipping\Model\Carrier\AbstractCarrierInterface, boolean returned»:
+	 * https://github.com/mage2pro/core/issues/193
 	 * @param int|null $sid [optional]
+	 * @return IM|false
 	 */
-	function aroundCreate(Sb $sb, \Closure $f, string $c, $sid = null):IM {/** @var $r */
+	function aroundCreate(Sb $sb, \Closure $f, string $c, $sid = null) {/** @var $r */
 		if (!is_a($c, M::class, true)) {
 			$r = $f($c, $sid);
 		}

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
 	"name": "mage2pro/core"
-	,"version": "9.2.4"
+	,"version": "9.2.5"
 	,"description": "Mage2.PRO core package."
 	,"type": "magento2-module"
 	,"homepage": "https://mage2.pro"