Fix toCurrency to correctly strip currency sign #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zend_Currency::toCurrency has an option to return the currency formatted without the currency sign. It should also trim any whitespaces before or after the currency sign. However it did strip every whitespace from the formatted string, even if the given locale uses spaces to separate thousands groups. This commit fixes this error. Signed-off-by: Nagy Attila Gabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zend_Currency::toCurrency has an option to return the currency formatted without the currency sign. It should also trim any whitespaces before or after the currency sign. However it did strip every whitespace from the formatted string, even if the given locale uses spaces to separate thousands groups. For example when using the Hungarian locale instead of
12 345it did return12345.This can affect some plugins that depend on the zendframework, for example the Mageplaza_CurrencyFormatter.
This commit fixes this error, and adds some test around it.