-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature - Dedicated MegaMenu Cache #5
base: master
Are you sure you want to change the base?
Conversation
Active class could do with some improvements. Currently a very very simple jQuery snippet |
@kestraly Thanks for pushing your patch I have tried to check and see the time speed same my patch in file Block/Menu.php but my patch is keeping active current category. If possible you can check it and let me know. |
Tested your solution, but it's not sufficient Real World Stats 1000 category store Uncached Load Time Your Cached Version Load Time My Pull Request Load Time |
If we can improve the jQuery to addClass('active') to all the correct parents and children, it would be a perfect solution |
…ive categories and their parents
@kestraly I have tested my solution and your solution when cache enabled, please check my result: note: Please let me know how to you test it. |
I used the Magento profiler, which seemed to give pretty accurate results |
I have tested with the Magento profiler. The second time when enabled cache your code still shows in the Magento profiler seems not a standard cache of Magento. The default Magento when caching the second time will not show in Magento profiler. If possible please check it and let me know. |
To see the menu cache in action, you have to disable full page cache. Enable the Menu Cache and load the page two times. The first time to generate the menu cache, you will see an initial load. The page reload and you will see the templates for the menu .phtml files load in a fraction of time |
Adds Dedicated Menu Cache to reduce page load down.
On a regular uncached page, the mega menu would need to load from the database, creating excess load and poor performance for page speed TTFB.
Changes add a cache to the System / Cache.
This means when Page Cache is flushed, it does not affect the mega menu cache and page TTFB.
Requires addtional changes to reneable the is active feature