Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: add korean language support #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jessehj
Copy link

@jessehj jessehj commented Mar 8, 2021

Add Korean locale type for translate to korean month and week names.

Comment on lines +163 to +164
case 'ko':
return ['일', '월', '화', '수', '목', '금', '토'];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, are these translation correct?
These are the translations I found, please correct me if I'm wrong

Monday -월요일
Tuesday - 화요일
Wednesday - 수요일
Thursday - 목요일
Friday - 금요일
​Saturday - 토요일
Sunday - 일요일

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are correct.
What I wrote is an abbreviation.
I'm affraid there is little space. but it doesn't matter.
I will follow your judgement
Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants