Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Commit

Permalink
Merge pull request #5 from magiclabs/jerryliu-sc-62139-deprecation-of…
Browse files Browse the repository at this point in the history
…-testnet-in-mobile-sdks

* make chainId nullable
  • Loading branch information
Ethella authored Sep 28, 2022
2 parents 33d4708 + 727d50c commit e3676da
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
6 changes: 2 additions & 4 deletions link.magic.unity.sdk/Scripts/Magic.cs
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ public Magic(string apikey, CustomNodeConfiguration config, string locale = "en-
public enum EthNetwork
{
Mainnet,
Kovan,
Rinkeby,
Rposten
Goerli,
}
}
}
5 changes: 3 additions & 2 deletions link.magic.unity.sdk/Scripts/Relayer/UrlBuilder.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using JetBrains.Annotations;
using link.magic.unity.sdk.Utility;
using UnityEngine;

Expand Down Expand Up @@ -51,10 +52,10 @@ internal class CustomNodeOptions : BaseOptions
[Serializable]
public class CustomNodeConfiguration
{
[SerializeField] internal int chainId;
[SerializeField] [CanBeNull] internal int? chainId;
[SerializeField] internal string rpcUrl;

public CustomNodeConfiguration(string rpcUrl, int chainId)
public CustomNodeConfiguration(string rpcUrl, int? chainId)
{
this.rpcUrl = rpcUrl;
this.chainId = chainId;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "link.magic.unity.sdk",
"displayName": "Magic Link Unity SDK",
"description": "The Magic Link Unity SDK provides access to Magic Key Management System and interact with Blockchain.",
"version": "0.2.0",
"version": "1.1.0",
"unity": "2021.3",
"author": {
"name": "Magic Labs Inc."
Expand Down

0 comments on commit e3676da

Please sign in to comment.