-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints support for checkboxes #433
Conversation
Sorry I don't have much time to test this right now, but my first question is: what if a user only wants hints for some of the questions? And what if the list-length doesn't match the number of questions? Should it raise an error or just guess? Maybe a dict would be a better choice to clearly map hints to a specific choice? Or does this lead to other problem? Not really stuff you need to answer, just what pops into my head when looking at the changes |
I agree that dict would be better. I just followed the example from #340 . I'll update my PR later |
I updated my PR:
Please take a look @Cube707 |
@Cube707 any updates on when you can check it out? |
ca5c812
to
2336b75
Compare
that makes them usable identically as the original tuple they where constructed from
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry it took so long, but I now had the time to fix it all up
5c895e5
to
0a2330c
Compare
0a2330c
to
d0155e5
Compare
This PR addresses #340 in this repo.
I also would like to use this feature for mac-cleanup/mac-cleanup-py#80
If this looks okay, I'll create the tests. Thank you for the awesome package!