Skip to content
This repository has been archived by the owner on Mar 12, 2021. It is now read-only.

Changed the setting to use latest release versions for every image by… #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgokden
Copy link
Contributor

@bgokden bgokden commented Dec 5, 2019

… default.

  • istio adapter and installer images converted to release images.

… default.

- istio adapter and installer images converted to release images.
Copy link

@jason-magnetic-io jason-magnetic-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using 'latest' is always a bad idea - it's a source of waste
How will the person debugging an issue know precisely what "latest" meant when the issue occurred?
Without wasting time guessing, assuming, etc?

@dennis-bell
Copy link

Agree on shortterm for the MVP, but would like we create a JIRA where we start using actual versions everywhere.

@bgokden
Copy link
Contributor Author

bgokden commented Dec 5, 2019

@jason-magnetic-io these are the default values. Users can set versions in config.yml while installing.

vamp install --configuration ./config.yml --certificate-output-path ./cert.crt

config.yaml used in test:

rootPassword: $ROOTPASSWORD
databaseUrl:
databaseName: vamp
imageName: $KUBIST_IMAGE_NAME
repoUsername: $REPO_USERNAME
repoPassword: $REPO_PASSWORD
imageTag: $KUBIST_IMAGE_TAG
mode: IN_CLUSTER
istioInstallerImage: $ISTIO_INSTALLER_IMAGE
istioAdapterImage: $ISTIO_ADAPTER_IMAGE

I also like versioned images, but I also don't want to update defaults every day.
I am open to recommendations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants