Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use version type rather than strings #14

Merged
merged 2 commits into from
Mar 19, 2024
Merged

refactor: use version type rather than strings #14

merged 2 commits into from
Mar 19, 2024

Commits on Mar 19, 2024

  1. refactor: rename release interface 

    BREAKING CHANGE: the `SafeReleaseRepositoryInterface` was renamed to `SafeReleaseRepoActions`.

The former name was verbose and clumsy, and I had wanted to rename it for a while.
    @jacderida
    jacderida committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    f2dad2d View commit details
    Browse the repository at this point in the history

  2. refactor: use version type rather than strings 

    BREAKING CHANGE: the `semver::Version` type is used rather strings for working with versions.

The need for the version parsing test and tests for retrieving the latest version was removed. The
latter of those was only testing that returned string was a valid semantic version, which wouldn't
be possible with a `Version` type.
    @jacderida
    jacderida committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    5ae1e06 View commit details
    Browse the repository at this point in the history