fix: detect language error on /_next/data/ input (github#22419)

maied12 · Oct 26, 2021 · e3074d9 · e3074d9
1 parent 5100b55
commit e3074d9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/middleware/detect-language.js b/middleware/detect-language.js
@@ -36,7 +36,7 @@ function getUserLanguage(browserLanguages) {
 
 // determine language code from a path. Default to en if no valid match
 export function getLanguageCodeFromPath(path) {
-  const maybeLanguage = path.split('/')[path.startsWith('/_next/data/') ? 4 : 1].slice(0, 2)
+  const maybeLanguage = (path.split('/')[path.startsWith('/_next/data/') ? 4 : 1] || '').slice(0, 2)
   return languageCodes.includes(maybeLanguage) ? maybeLanguage : 'en'
 }
 

diff --git a/tests/unit/detect-language.js b/tests/unit/detect-language.js
@@ -6,6 +6,10 @@ describe('detect-language - getLanguageCodeFromPath', () => {
     expect(getLanguageCodeFromPath('/_next/data/development/ja/articles/foo')).toBe('ja')
   })
 
+  test('should not error on /_next/data/ input', () => {
+    expect(getLanguageCodeFromPath('/_next/data/')).toBe('en')
+  })
+
   test('should return for paths with an extension', () => {
     expect(getLanguageCodeFromPath('/ja.json')).toBe('ja')
     expect(getLanguageCodeFromPath('/_next/data/development/ja.json')).toBe('ja')