Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the API authentication error message more general. #50

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

iamdharmesh
Copy link
Collaborator

Description of the Change

The PR updates the authentication error message to be more generic so that it can cover errors for both API key and access token authentication.

image

Closes #49

How to test the Change

  1. Authenticate via the new OAuth flow
  2. In the database, modify the mailchimp_sf_access_token value to make it invalid
  3. Refresh the settings page to see the error message and make sure it says "Authentication failed."

Changelog Entry

Changed - Make the API authentication error message more general.

Credits

Props @dkotter @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh self-assigned this Aug 20, 2024
@github-actions github-actions bot added this to the 1.6.0 milestone Aug 20, 2024
@dkotter dkotter marked this pull request as ready for review August 20, 2024 14:33
@dkotter dkotter merged commit 5ef2ddc into develop Aug 20, 2024
5 of 8 checks passed
@dkotter dkotter deleted the fix/49 branch August 20, 2024 14:33
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message mentions API key even if using access token
2 participants