Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the OAuth service URL #52

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update the OAuth service URL #52

merged 1 commit into from
Aug 26, 2024

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Aug 26, 2024

Description of the Change

This PR updates the URL that we use for our OAuth service

How to test the Change

Either in a new environment or in an existing environment where you've disconnected your Mailchimp account, run through the OAuth flow and ensure it connects correctly and all API requests work as expected.

Changelog Entry

n/a as the changelog from #47 is sufficient

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 1.6.0 milestone Aug 26, 2024
@dkotter dkotter self-assigned this Aug 26, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label Aug 26, 2024
@dkotter
Copy link
Collaborator Author

dkotter commented Aug 26, 2024

Note that in my testing, this new service works as expected but there are still branding changes that need made.

Mailchimpapp.com

  • The app on the Mailchimp side doesn't show a logo at all and shows WordPress with a lower case p:
Login with app Authorize app

@dkotter
Copy link
Collaborator Author

dkotter commented Aug 26, 2024

Following up on the above, found out that the Mailchimp app is created under the 10up account so I was able to update the text and logo, so that part looks better now:

Login to Mailchimp Authorize Mailchimp

@dkotter dkotter merged commit 68b31e2 into develop Aug 26, 2024
8 of 9 checks passed
@dkotter dkotter deleted the fix/oauth-url branch September 16, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants