Add credo for static code analysis #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I totally missed this! I'll have to figure out how to turn on email notifications for this project :) Thank you for this, it's a good first step, and should be a risk-free merge. You're more than welcome to embark on a code-clean-up journey if you'd like to volunteer your time for it – personally I like the recommendations in most of the popular Elixir style guides, but I'm not dogmatic about it. Thanks again! |
|
No worries. Okay. I will try to do some exploration on the recommendations from other Elixir projects and send PRs whenever possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #75 I have added credo package and a basic credo configuration for static code analysis.
Currently, credo is reporting around 500 issues:
With this as starting point, we can start working towards fixing the issues reported by credo.
And for the consistency issues issues we might have to decide on the code format we are going to use throughout the project.