Merge pull request #2782 from mainmatter/renovate/major-eslint-monorepo

chore(deps): update dependency eslint to v9
mainmatter · Dec 30, 2024 · 59f07f8 · 59f07f8
2 parents a3355b7 + 514b9a9
commit 59f07f8
Show file tree

Hide file tree

Showing 12 changed files with 186 additions and 178 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -187,6 +187,7 @@ export default [
     files: ['**/tests/**/*.js'],
     rules: {
       'qunit/require-expect': ['error', 'except-simple'],
+      'no-unused-vars': 'off',
     },
   },
 ];
diff --git a/packages/classic-test-app/package.json b/packages/classic-test-app/package.json
@@ -49,7 +49,7 @@
     "ember-source": "5.12.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "3.0.0",
-    "eslint": "8.57.1",
+    "eslint": "9.17.0",
     "express": "4.21.2",
     "glob": "11.0.0",
     "globals": "15.12.0",

diff --git a/packages/classic-test-app/server/demo-api.js b/packages/classic-test-app/server/demo-api.js
@@ -6,6 +6,5 @@ var app = express();
 var server = require('./index.js')(app);
 
 app.listen(process.env.PORT, function () {
-  // eslint-disable-next-line no-console
   console.log('Server started on port ' + process.env.PORT);
 });
diff --git a/packages/ember-simple-auth/package.json b/packages/ember-simple-auth/package.json
@@ -57,7 +57,7 @@
     "@typescript-eslint/parser": "8.18.2",
     "concurrently": "9.1.1",
     "ember-template-lint": "6.0.0",
-    "eslint": "8.57.1",
+    "eslint": "9.17.0",
     "prettier": "3.3.3",
     "rollup": "4.25.0",
     "rollup-plugin-copy": "3.5.0",

diff --git a/packages/test-app/config/fastboot-testing.js b/packages/test-app/config/fastboot-testing.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-redeclare */
 module.exports = function () {
   return {
     buildSandboxGlobals(defaultGlobals) {

diff --git a/packages/test-app/config/fastboot.js b/packages/test-app/config/fastboot.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-redeclare */
 module.exports = function () {
   return {
     buildSandboxGlobals(defaultGlobals) {

diff --git a/packages/test-app/package.json b/packages/test-app/package.json
@@ -63,7 +63,7 @@
     "ember-source": "5.12.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "3.0.0",
-    "eslint": "8.57.1",
+    "eslint": "9.17.0",
     "express": "4.21.2",
     "fastboot-app-server": "4.1.4",
     "glob": "11.0.0",

diff --git a/packages/test-app/server/demo-api.js b/packages/test-app/server/demo-api.js
@@ -6,6 +6,5 @@ var app = express();
 var server = require('./index.js')(app);
 
 app.listen(process.env.PORT, function () {
-  // eslint-disable-next-line no-console
   console.log('Server started on port ' + process.env.PORT);
 });
diff --git a/packages/test-app/tests/acceptance/authentication-test.js b/packages/test-app/tests/acceptance/authentication-test.js
@@ -102,7 +102,7 @@ module('Acceptance: Authentication', function (hooks) {
       await authenticateSession({});
       try {
         await visit('/auth-error');
-      } catch (e) {
+      } catch (_e) {
         // ignore the error
       }
 

diff --git a/packages/test-esa/package.json b/packages/test-esa/package.json
@@ -55,7 +55,7 @@
     "ember-source": "5.12.0",
     "ember-source-channel-url": "3.0.0",
     "ember-try": "3.0.0",
-    "eslint": "8.57.1",
+    "eslint": "9.17.0",
     "express": "4.21.2",
     "glob": "11.0.0",
     "handlebars": "4.7.8",

diff --git a/packages/test-esa/tests/unit/authenticators/oauth2-password-grant-test.js b/packages/test-esa/tests/unit/authenticators/oauth2-password-grant-test.js
@@ -422,7 +422,6 @@ module('OAuth2PasswordGrantAuthenticator', function (hooks) {
             let body = parsePostData(requestBody);
 
             if (body.token_type_hint === 'refresh_token') {
-              // eslint-disable-next-line qunit/no-conditional-assertions
               assert.deepEqual(body, {
                 token_type_hint: 'refresh_token',
                 token: 'refresh token!',