show how to extend the session service in the README #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuing from my comment here, there isn't any info about this in the docs so yet. mainmatter#2285 (comment)
mcfiredrill
changed the title
bertdeblock
reviewed
Jun 24, 2021
README.md
Outdated
| * @var {Service} | ||
| */ | ||
| handleAuthentication() { | ||
| this.router.transitionTo('dashboard.boards'); |
There was a problem hiding this comment.
I would write super.handleAuthentication('dashboard.boards') instead. That way, the default logic defined here is kept as well.
There was a problem hiding this comment.
@bertdeblock How would I pass owner if I did that ?
export function handleSessionAuthenticated(owner, routeAfterAuthentication) {There was a problem hiding this comment.
|
Thank you for sharing this! It helpt me a lot! |
|
Hi, it's been awhile, but I've updated the example to use super per @bertdeblock 's suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from my comment here, there isn't any info about this in the docs so yet.
#2285 (comment)
As far as I understand this is the preferred way to set a
routeAfterAuthenticationso this should definitely be in the docs, right?