-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post/ ember-vite-codemod #2648
base: master
Are you sure you want to change the base?
Conversation
6c2fa73
to
b7c897f
Compare
b7c897f
to
8b97616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great post overall. I did some tweaking in my suggestions and used some Grammarly to help. Feel free to accept or pass on any of them 👍
Co-authored-by: Chris Manson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good! Or, to use typical High French Praise: "not bad". I left a bunch of minor comments, but two things:
- These blog posts always need a closing call to action. "Mainmatter's Ember Initiative aims to improve Ember for the entire web. We need your support: talk to your employer about sponsoring our effort, spread the word, and follow our progress on this blog. You can get in touch with us" etc.
- I'm not too sure what the goal of this blog post is between:
- announcing the codemod (great for Ember developers on a recent version who want to upgrade to Vite)
- explaining what this codemod does and how to use it
- explaining how this codemod works and how you approached it (and future versions)
- explaining what codemods are and how to write one for a different problem
You could state clearly in the intro "we are excited to release this codemod, which will make it easier to upgrade to Vite, and we're going to explain what it does and how you can use it" for instance. This is just my opinion, but it feels like it needs some focus one one (maybe two) of these threads
Thanks for the review @KevinBongart 🙏 There are a few suggestions that I think could be discussed, but I'll apply most of them tomorrow morning. |
e36d71a
to
14a8995
Compare
14a8995
to
6ce2c52
Compare
Co-authored-by: Kevin Bongart <[email protected]>
preview https://deploy-preview-2648--objective-northcutt-37494c.netlify.app/blog/2025/03/07/ember-vite-codemod/