-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: init @sheepdog/vanilla
#253
Open
paoloricciuti
wants to merge
15
commits into
main
Choose a base branch
from
sheepdog-vanilla
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sheepdog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initialize
@sheepdog/vanilla
So, i think i've almost finished the vanilla version (i still need to write all the tests tho)...I'm a bit puzzled by a couple of things:
for instance i think it makes perfect sense...you get an event for each state (minus isRunning but you can infer that with a couple of events)
I'm, not super convinced about the ones for the task...technically also error ,finish and cancel should have the prefix instance- because at the end of the day it's one of the instances that is erroring, or starting or etc etc. so maybe it might make sense to just drop instance- everywhere?
3. do you think we should pass something to the events? Like if you do
I think we need to bikeshed it a bit and try to build something with it to get the feel but i'd say i'm pretty happy with the result