Fixed to work under new versions React Native (tested on 0.38) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleydw
reviewed
Jan 8, 2017
| @@ -28,9 +28,6 @@ class NumberPicker extends Component { | |||
| if (this.props.onSelect) | |||
| this.props.onSelect(event.nativeEvent.value); | |||
|
|
|||
| if (this.refs[REF_PICKER] && this.state.selectedIndex !== event.nativeEvent.value) | |||
There was a problem hiding this comment.
This used to set the default value, does it not work in later versions?
There was a problem hiding this comment.
It forces the client to update the selectedIndex prop every time an "onSelect" event is received, which, while logical, may not be immediately apparent (adding it to the README would fix that).
But the bigger problem when I was testing was that setting the selectedIndex prop on the element couldn't keep up with the native events that kept resetting the picker to it's original value thanks to these two lines. The whole thing then became unusable. I'm open to any ideas on how to fix that.
| "description": "React Native Android NumberPicker", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/fixd/react-native-numberpicker.git" |
There was a problem hiding this comment.
Need to undo this and the author change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.