Drop support for Rails < 6, add support for Rails 8 & Ruby 3.4 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunosedler
force-pushed
the
bs/add-support-for-rails-8
branch
from
ecc0505 to
efcc9fa
Compare
brunosedler
changed the title
tecden
approved these changes
Jan 28, 2025
| @@ -1,15 +1,15 @@ | |||
| source 'https://rubygems.org' | |||
|
|
|||
| # Runtime dependencies | |||
| gem 'activerecord', '~>5' | |||
| gem 'mysql2', '~>0.4.10' | |||
There was a problem hiding this comment.
Wieso schmeißen wir eigentlich MySQL für PG raus?
There was a problem hiding this comment.
I removed (among others) the Gemfile.5.2.mysql2 and and created the new Gemfile.8.0.pg. The changes apparently where so few, that git thought I moved the file. That's why we have mysql changes in the pg file.
codener
approved these changes
Jan 29, 2025
CHANGELOG.md
Outdated
| @@ -7,10 +7,12 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html | |||
| ## Unreleased | |||
|
|
|||
| ### Breaking changes | |||
| - Drop support for Rails < 6.1 | |||
There was a problem hiding this comment.
I'd append "This also drops support for MySQL, which had only been present for Rails < 6."
brunosedler
force-pushed
the
bs/add-support-for-rails-8
branch
from
233a4ab to
5310858
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.