-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt6 support v2 #125
base: master
Are you sure you want to change the base?
Qt6 support v2 #125
Conversation
Plugins and libraries are supposed to be coinstallable leading to systems having both of them available at the same time. As a precaution to accidential mixups of libraries that lead to hard to analyze runtime issues due to ABI incompatibilities, always link publically against the versioned Qt library.
This should already be default config for Qt5.
This option name is a very common practice in many projects, make it easier to detect.
@dobey I am now looking into the coinstallability of qt5 and qt6 version of maliit and need a little bit of input what you desire. Specifically, how do you want to name the Qt6 version? from the list of installed files I will need to add a Qt6 suffix at least for the following artifacts:
So, for me the main question is, do you want to go with "maliit3" or "maliit6" or "maliit-qt6"? For KDE we typically use the Qt major version as suffix, but there we already had that suffix aligned with the respective Qt version. |
For Qt5 versions the name is not changed, only append 6 for Qt6 builds.
This introduces a 6 suffix for each maliit library basename and that only for Qt6 builds. Changing the library name allows to still used the project version for incompatible SONAME changes.
This is the state with the new patch set from today (please note, I am open to any changes, dropping of patches to makes less changes in order to allow less coinstallability)
Open points from my list:
|
08d3067
to
2598e27
Compare
@dobey Any comment from your side? With Qt5 going fully EoL in 5 months (May 2025) and later distros starting to consider dropping any remaining packages depending on Qt5 still etc it'd be nice to have a way forward here followed by Maliit component releases also compatible with Qt6 (it's been nearly 2.5 years since 2.3.x) :) |
@@ -552,6 +598,7 @@ if(enable-tests) | |||
tests/ut_maliit_glib_settings/ut_maliit_glib_settings.c | |||
tests/ut_maliit_glib_settings/mockmaliitserver.c | |||
tests/ut_maliit_glib_settings/mockmaliitserver.h) | |||
set_target_properties(ut_maliit_glib_settings PROPERTIES OUTPUT_NAME "ut_maliit_glib_settings${MALIIT_EXE_SUFFIX}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test also needs to be updated to execute this after rename because it currently fails to run with Unable to find executable: ut_maliit_glib_settings
(because it's called ut_maliit_glib_settings6
etc)
datadir=${datarootdir} | ||
pluginsdatadir=${datadir}/maliit/plugins | ||
pluginsdatadir=${datadir}/maliit@MALIIT_LIB_SUFFIX@/plugins | ||
|
||
Name: Maliit Plugins | ||
Description: Maliit provides a flexible and cross platform input method framework. It is usable on all MeeGo user experiences, and in other GNU/Linux distributions as well. | ||
Version: @PROJECT_VERSION@ | ||
Requires: maliit-framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires: maliit-framework | |
Requires: maliit@MALIIT_LIB_SUFFIX@-framework |
This is a work in progress setup that essentially is a cleaned up revision of #121 .
Done:
Next: