Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update name #1

Closed
wants to merge 4 commits into from
Closed

update name #1

wants to merge 4 commits into from

Conversation

mallek
Copy link
Owner

@mallek mallek commented May 16, 2024

Summary by CodeRabbit

  • Refactor: Updated the user prompt in SetupPlayer function for better clarity. Users will now be asked to "Please enter your character name:" instead of "Please enter your name:".
  • Chore: Modernized and simplified project setup by transitioning from MSBuild to Microsoft.NET.Sdk, updating the target framework to net452, and adding PackageReferences for Microsoft.CSharp and System.Data.DataSetExtensions. This change does not affect the functionality but improves maintainability and compatibility with modern development environments.

Copy link

github-actions bot commented May 16, 2024

Image description CodeRabbit

Walkthrough

The changes primarily focus on enhancing user experience by modifying prompt messages in the game setup and modernizing project setup. The game now asks for a "character name" instead of a "name", providing clearer instructions to users. The project files have been updated to use Microsoft.NET.Sdk, targeting net452, and adding specific package references.

Changes

File(s) Summary
Oasis/Game.cs Updated the prompt message from "Please enter your name:" to "Please enter your character name:", improving clarity in the game setup process.
Oasis.Engine/Oasis.Engine.csproj, Oasis.Tests/Oasis.Tests.csproj, Oasis/Oasis.csproj Modernized the project setup by transitioning from MSBuild to Microsoft.NET.Sdk, targeting net452, and adding PackageReferences for Microsoft.CSharp and System.Data.DataSetExtensions.

🐇💻

In the land of code, where the rabbit hops,

Changes are made, and the old way drops.

A character's name, not just any name,

Makes the game setup clear, not the same.

Project files gleam with a modern glow,

Onward we hop, ready to grow! 🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 636e827 and 583fc00 commits.
Files selected (1)
  • Oasis/Game.cs (1)
Files skipped from review due to trivial changes (1)
  • Oasis/Game.cs
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 583fc00 and c70a3a9 commits.
Files selected (1)
  • Oasis/Game.cs (1)
Files skipped from review due to trivial changes (1)
  • Oasis/Game.cs
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between c70a3a9 and 1b83988 commits.
Files selected (3)
  • Oasis.Engine/Oasis.Engine.csproj (1)
  • Oasis.Tests/Oasis.Tests.csproj (3)
  • Oasis/Oasis.csproj (1)
Files skipped from review due to trivial changes (3)
  • Oasis.Engine/Oasis.Engine.csproj
  • Oasis.Tests/Oasis.Tests.csproj
  • Oasis/Oasis.csproj
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 1b83988 and 04797b2 commits.
Files selected (1)
  • Oasis/Game.cs (1)
Files skipped from review due to trivial changes (1)
  • Oasis/Game.cs
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@mallek mallek closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant