Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improvements #37

wants to merge 3 commits into from

Conversation

MFlisar
Copy link

@MFlisar MFlisar commented Dec 12, 2016

This "fixes" following: #29 #30

I did following:

SimpleMediaFensterPlayerController

  • corrected layout for seekbar and time text views - old weight based layouts may have lead to line breaks on small screens if durations are long (>1 hour for example)
  • add the ability to theme the seekbar to a custom color (android >= 21 only)
  • added the ability to disable the next/prev buttons

General

  • added some common functions of both controllers to the common interface, namely boolean isShowing() and boolean isFirstTimeLoading()

* corrected layout for seekbar and time text views - old weight based layouts may have lead to line breaks on small screens if durations are long
* add the ability to theme the seekbar to a custom color (android >= 21)
* added the ability to disable the next/prev buttons
…ce, namely `boolean isShowing()` and `boolean isFirstTimeLoading()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant