-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for jQuery 3.0 load() deprecation. Fixes #778 #779
base: master
Are you sure you want to change the base?
Conversation
LGTM ... in the meantime you should be able to use jQuery Migrate 3.0 to get the current version running again. |
Thanks for your fix. I can confirm this resolves the issue with the latest version of jQuery. |
I think the project is dead. |
Yes, but it still works well. |
@jakeparis yeap, we use it too. But, I think the author should give other persons write access to maintain the project if he can't. |
It's a shame as Cycle2 is a really nice plugin |
@malsup are you alive? |
thanks for this fix. after it cycle2 worked with my jquery v3.2.1. |
Thank you so much for the fix. That fixed one of my slide shows, but I also use the carousel feature with Cycle2 and that has an additional jquery file. This feature doesn't seem to work with jquery 3.0. Is there any way to tell what might need to be updated to get the carousel to work with Jquery 3.0? |
fix for jQuery 3.0 deprecate .load() function jakeparis referenced this pull request on Jun 23, 2016 malsup#779 cycle2 & center incompatible with JQuery 3.0.0 malsup#778 malsup#778
jQuery 3.0 has deprecated the load function. In this case, we wanted to check for something on the load event anyway, so we switch to using .on('load')