Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for jQuery 3.0 load() deprecation. Fixes #778 #779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakeparis
Copy link

jQuery 3.0 has deprecated the load function. In this case, we wanted to check for something on the load event anyway, so we switch to using .on('load')

@jakeparis jakeparis changed the title Fix for jQuery 3.0 load() deprecation Fix for jQuery 3.0 load() deprecation. Fixes #778 Jun 23, 2016
@dmethvin
Copy link

LGTM ... in the meantime you should be able to use jQuery Migrate 3.0 to get the current version running again.

@robinwilson16
Copy link

Thanks for your fix. I can confirm this resolves the issue with the latest version of jQuery.
I notice that no changes seem to have been committed for over two years so am wondering if this project is still active?

@ghost
Copy link

ghost commented Nov 8, 2016

I think the project is dead.

@jakeparis
Copy link
Author

Yes, but it still works well.

@ghost
Copy link

ghost commented Nov 9, 2016

@jakeparis yeap, we use it too. But, I think the author should give other persons write access to maintain the project if he can't.

@robinwilson16
Copy link

It's a shame as Cycle2 is a really nice plugin

@ghost
Copy link

ghost commented Nov 14, 2016

@malsup are you alive?

@tmuka
Copy link

tmuka commented Sep 14, 2017

thanks for this fix. after it cycle2 worked with my jquery v3.2.1.

@FisherFast
Copy link

Thank you so much for the fix. That fixed one of my slide shows, but I also use the carousel feature with Cycle2 and that has an additional jquery file. This feature doesn't seem to work with jquery 3.0.

Is there any way to tell what might need to be updated to get the carousel to work with Jquery 3.0?

iam-sysop pushed a commit to iam-sysop/cycle2 that referenced this pull request Sep 21, 2019
fix for jQuery 3.0 deprecate .load() function
jakeparis referenced this pull request on Jun 23, 2016 malsup#779
cycle2 & center incompatible with JQuery 3.0.0 malsup#778 malsup#778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants