Skip to content

Commit

Permalink
Move linting checks out of analysis workflow, since that runs on the …
Browse files Browse the repository at this point in the history
…PR target
  • Loading branch information
poodlewars committed Feb 21, 2025
1 parent 268e246 commit 9ae9220
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/analysis_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,29 +31,6 @@ on:

jobs:

run_linting_checks:
name: Linting checks
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/[email protected]

- name: Install linters
run: |
python3 build_tooling/format.py --install-tools
- name: Lint Python
if: always()
run: |
python3 build_tooling/format.py --check --type python \
|| 1 # formatting not enforced yet
- name: Lint C++
if: always()
run: |
python3 build_tooling/format.py --check --type cpp \
|| 1 # formatting not enforced yet
get_commits_to_benchmark:
name: Get tag commits
runs-on: ubuntu-22.04
Expand Down
23 changes: 23 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,29 @@ jobs:
cibuildwheel_ver: "2.21.3"
force_update: false

run_linting_checks:
name: Linting checks
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/[email protected]

- name: Install linters
run: |
python3 build_tooling/format.py --install-tools
- name: Lint Python
if: always()
run: |
python3 build_tooling/format.py --check --type python \
|| true # formatting not enforced yet
- name: Lint C++
if: always()
run: |
python3 build_tooling/format.py --check --type cpp \
|| true # formatting not enforced yet
common_config:
needs: [cibw_docker_image]
runs-on: ubuntu-22.04
Expand Down

0 comments on commit 9ae9220

Please sign in to comment.