Backport fixes to make newer lib tool code work correctly

- Replaces a few function calls with their old names
- Removes some timeseries descriptor bindings exposed

cpp/arcticdb/stream/python_bindings.cpp

@@ -101,16 +101,12 @@ void register_types(py::module &m) {
         .def_property_readonly("fields", [](const TimeseriesDescriptor& desc){
             return field_collection_to_ref_vector(desc.fields());
         }).def_property_readonly("normalization", [](const TimeseriesDescriptor& self) {
-            return python_util::pb_to_python(self.normalization());
-        }).def_property_readonly("sorted", [](const TimeseriesDescriptor& self) {
-            return self.sorted();
-        }).def_property_readonly("index", [](const TimeseriesDescriptor& self) {
-            return self.index();
+            return python_util::pb_to_python(self.proto().normalization());
         }).def_property_readonly("total_rows", [](const TimeseriesDescriptor& self) {
-            return self.total_rows();
+            return self.proto().total_rows();
         }).def_property_readonly("next_key", [](const TimeseriesDescriptor& self) -> std::optional<AtomKey> {
             if (self.proto().has_next_key()){
-                return key_from_proto(self.proto().next_key());
+                return decode_key(self.proto().next_key());
             }
             return std::nullopt;
         });

cpp/arcticdb/toolbox/library_tool.cpp

@@ -11,6 +11,7 @@
 #include <arcticdb/codec/default_codecs.hpp>
 #include <arcticdb/entity/atom_key.hpp>
 #include <arcticdb/entity/protobufs.hpp>
+#include <arcticdb/entity/protobuf_mappings.hpp>
 #include <arcticdb/entity/types.hpp>
 #include <arcticdb/pipeline/pipeline_utils.hpp>
 #include <arcticdb/storage/library.hpp>
@@ -45,7 +46,7 @@ ReadResult LibraryTool::read(const VariantKey& key) {
             // We construct a dummy atom key in case of a RefKey to be able to build the read_result
             [](const RefKey& key){return AtomKeyBuilder().build<KeyType::VERSION_REF>(key.id());},
             [](const auto&){});
-    return pipelines::read_result_from_single_frame(frame_and_descriptor, atom_key);
+    return pipelines::make_read_result_from_frame(frame_and_descriptor, atom_key);
 }
 
 Segment LibraryTool::read_to_segment(const VariantKey& key) {
@@ -70,7 +71,7 @@ TimeseriesDescriptor LibraryTool::read_timeseries_descriptor(const VariantKey& k
 
 void LibraryTool::write(VariantKey key, Segment segment) {
     storage::KeySegmentPair kv{std::move(key), std::move(segment)};
-    store()->write_compressed_sync(kv);
+    store()->write_compressed_sync(std::move(kv));
 }
 
 void LibraryTool::overwrite_segment_in_memory(VariantKey key, SegmentInMemory& segment_in_memory) {
@@ -92,7 +93,7 @@ SegmentInMemory LibraryTool::overwrite_append_data(
     const auto& tsd = old_segment_in_memory.index_descriptor();
     std::optional<AtomKey> next_key = std::nullopt;
     if (tsd.proto().has_next_key()){
-        next_key = key_from_proto(tsd.proto().next_key());
+        next_key = decode_key(tsd.proto().next_key());
     }
 
     auto stream_id = util::variant_match(key, [](const auto& key){return key.id();});

cpp/arcticdb/toolbox/library_tool.hpp

@@ -54,6 +54,8 @@ class LibraryTool {
 
     std::vector<VariantKey> find_keys(arcticdb::entity::KeyType);
 
+    bool key_exists(const VariantKey& key);
+
     std::vector<bool> batch_key_exists(const std::vector<VariantKey>& keys);
 
     std::string get_key_path(const VariantKey& key);

cpp/arcticdb/version/local_versioned_engine.hpp

@@ -406,6 +406,8 @@ class LocalVersionedEngine : public VersionedEngine {
         return store()->current_timestamp();
     }
 
+    const arcticdb::proto::storage::VersionStoreConfig& cfg() const override { return cfg_; }
+
 protected:
     VersionedItem compact_incomplete_dynamic(
             const StreamId& stream_id,
@@ -429,7 +431,6 @@ class LocalVersionedEngine : public VersionedEngine {
     );
 
     std::shared_ptr<Store>& store() override { return store_; }
-    const arcticdb::proto::storage::VersionStoreConfig& cfg() const override { return cfg_; }
     std::shared_ptr<VersionMap>& version_map() override { return version_map_; }
     SymbolList& symbol_list() override { return *symbol_list_; }
     std::shared_ptr<SymbolList> symbol_list_ptr() { return symbol_list_; }

python/arcticdb/toolbox/library_tool.py

@@ -7,6 +7,7 @@
 import pandas as pd
 
 from arcticdb.version_store._normalization import FrameData
+from arcticdb.supported_types import ExplicitlySupportedDates
 from arcticdb_ext.codec import decode_segment
 from arcticdb_ext.storage import KeyType
 from arcticdb_ext.stream import SegmentInMemory
@@ -15,6 +16,7 @@
 from arcticdb.version_store._normalization import denormalize_dataframe, normalize_dataframe
 
 VariantKey = Union[AtomKey, RefKey]
+VersionQueryInput = Union[int, str, ExplicitlySupportedDates, None]
 
 _KEY_PROPERTIES = {
     key_type: {k: v for k, v in vars(key_type).items() if isinstance(v, property)} for key_type in (AtomKey, RefKey)