Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin MSVC version #2011

Closed
wants to merge 3 commits into from
Closed

Pin MSVC version #2011

wants to merge 3 commits into from

Conversation

vasil-pashov
Copy link
Collaborator

@vasil-pashov vasil-pashov commented Nov 19, 2024 •
edited
Loading

Reference Issues/PRs

The MSVC compiler in 17.12.0 (MSVC 19.42.34433.0) fails to compile folly. microsoft/vcpkg#42233

In order to avoid such problems in future we are pinning the MSVC version used by the CI.

  • choco is used to download and install the required build tools version
  • Custom triplet file is added and the Windows CMake presets are updated to use it
  • The action used to discover is changed to a new one and the required toolset is pinned

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@vasil-pashov vasil-pashov force-pushed the fix-win-ci branch 30 times, most recently from b782f79 to dcfd484 Compare November 19, 2024 20:30
@vasil-pashov vasil-pashov force-pushed the fix-win-ci branch 21 times, most recently from 9e5200b to 9899180 Compare November 27, 2024 00:37
@vasil-pashov vasil-pashov changed the title Rollback MSVC version Pin MSVC version Nov 27, 2024
@vasil-pashov
Copy link
Collaborator Author

Closed as the code was merged as part of #2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunro jamesmunro jamesmunro approved these changes

@poodlewars poodlewars poodlewars approved these changes

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vasil-pashov @jamesmunro @poodlewars