Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developmental releases on demand #2190

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

ognyanstoimenov
Copy link
Collaborator

@ognyanstoimenov ognyanstoimenov commented Feb 19, 2025

Reference Issues/PRs

What does this implement or fix?

Change Type (Required)

  • Patch (Bug fix or non-breaking improvement)
  • Minor (New feature, but backward compatible)
  • Major (Breaking changes)
  • Cherry pick

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@github-actions github-actions bot added the patch label Feb 19, 2025
@ognyanstoimenov ognyanstoimenov changed the title Fix actions permissions Developmental releases on demand Feb 20, 2025
@github-actions github-actions bot added patch and removed patch labels Feb 20, 2025
@ognyanstoimenov ognyanstoimenov merged commit 29b8a26 into master Feb 20, 2025
151 of 152 checks passed
@ognyanstoimenov ognyanstoimenov deleted the ostoimenov/fix_release_scripts branch February 20, 2025 15:54
jamesmunro pushed a commit that referenced this pull request Feb 25, 2025
#### Reference Issues/PRs
<!--Example: Fixes #1234. See also #3456.-->
* New workflow that on trigger creates a dev release from current master
* Calculates what next version would be and names the release
`x.y.z.dev0+<master_sha>`
* Release scripts introduced in #2174 had some permissions/token issues.
This fixes them.

  * Not working (5.2.4 branch, check annotations);
  https://github.com/man-group/ArcticDB/actions/runs/13397301934
  https://github.com/man-group/ArcticDB/actions/runs/13409868194

  * Working (5.2.4 after applying this):
  * https://github.com/man-group/ArcticDB/actions/runs/13410089783

#### What does this implement or fix?

## Change Type (Required)
- [x] **Patch** (Bug fix or non-breaking improvement)
- [ ] **Minor** (New feature, but backward compatible)
- [ ] **Major** (Breaking changes)
- [ ] **Cherry pick**

#### Any other comments?

#### Checklist

<details>
  <summary>
   Checklist for code changes...
  </summary>
 
- [ ] Have you updated the relevant docstrings, documentation and
copyright notice?
- [ ] Is this contribution tested against [all ArcticDB's
features](../docs/mkdocs/docs/technical/contributing.md)?
- [ ] Do all exceptions introduced raise appropriate [error
messages](https://docs.arcticdb.io/error_messages/)?
 - [ ] Are API changes highlighted in the PR description?
- [ ] Is the PR labelled as enhancement or bug so it appears in
autogenerated release notes?
</details>

<!--
Thanks for contributing a Pull Request to ArcticDB! Please ensure you
have taken a look at:
- ArcticDB's Code of Conduct:
https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md
- ArcticDB's Contribution Licensing:
https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants