Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Change Type template and change label names #2196

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@

#### What does this implement or fix?

## Change Type (Required)
- [ ] **Patch** (Bug fix or non-breaking improvement)
- [ ] **Minor** (New feature, but backward compatible)
- [ ] **Major** (Breaking changes)
- [ ] **Cherry pick**

#### Any other comments?

#### Checklist
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ jobs:
id: get_increment_type
env:
PULL_REQUESTS: ${{ steps.pull_requests.outputs.pull_requests }}
MAJOR_LABEL: major
MINOR_LABEL: minor
PATCH_LABEL: patch
MAJOR_LABEL: "api break"
MINOR_LABEL: "enhancement"
PATCH_LABEL: "bug"
run: |
if [ -z "$PULL_REQUESTS" ]; then
echo "Error: No PRs found between branches" && exit 1
Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/automated_release.check_pr_labels.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Check Pull Request Labels
on:
pull_request:
types: [opened, labeled, unlabeled, synchronize]
branches: master
jobs:
check_labels:
runs-on: ubuntu-latest
permissions:
issues: write
pull-requests: write
steps:
- uses: mheap/github-action-required-labels@v5
with:
mode: exactly
count: 1
labels: |
patch
minor
major
add_comment: true
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@ jobs:
create-next-release-branch:
needs: [calculate-next-version, get-master-sha]
runs-on: ubuntu-latest
environment: TestPypi # For the branch restrictions token
permissions:
contents: write
outputs:
new_branch: ${{ needs.calculate-next-version.outputs.version }}
steps:
- name: Create branch ${{ needs.calculate-next-version.outputs.version }} from ${{ needs.get-master-sha.outputs.sha }}
uses: peterjgrainger/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.TAGGING_TOKEN }}
with:
branch: ${{ needs.calculate-next-version.outputs.version }}
sha: ${{ needs.get-master-sha.outputs.sha }}
Expand Down
81 changes: 0 additions & 81 deletions .github/workflows/automated_release.parse_pr_template.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:

- id: changelog
name: Release Changelog Builder
uses: mikepenz/release-changelog-builder-action@v3.7.3
uses: mikepenz/release-changelog-builder-action@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
8 changes: 6 additions & 2 deletions build_tooling/change_log.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
{
"categories": [
{
"title": "## ⚠️ Breaking Changes",
"labels": ["api break", "major"]
},
{
"title": "## 🚀 Features",
"labels": ["enhancement"]
"labels": ["enhancement", "minor"]
},
{
"title": "## 🐛 Fixes",
"labels": ["bug"]
"labels": ["bug", "patch"]
}
],
"pr_template": "- ${{TITLE}} (#${{NUMBER}})",
Expand Down
1 change: 0 additions & 1 deletion docs/mkdocs/mkdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ plugins:
group_by_category: true
docstring_options:
ignore_init_summary: false
allow_section_blank_line: true
docstring_section_style: spacy
heading_level: 2
inherited_members: true
Expand Down
Loading