Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap, sys-firmware: Add various linux-firmware packages #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ElectrodeYT
Copy link
Member

No description provided.

Copy link
Member

@no92 no92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qookei
Copy link
Member

qookei commented Aug 20, 2023

Why do we need linux-firmware on managarm?

@ikbenlike
Copy link

One nitpick: amd-ucode is the only package not prefixed with linux-firmware. Is there a particular reason for this?

@ElectrodeYT
Copy link
Member Author

Why do we need linux-firmware on managarm?

I plan on attempting to bring up a Radeon card, which would require firmware files from the amdgpu (and maybe the radeon) folder.
(For context, the nvidia card I was writing a driver for broke, so that plan has died)

In addition, there really is no point in not adding packages for other drivers such as i915. @no92 is also working on a intel GPU driver, which may require firmware files from the i915 folder.

The amd-ucode package was made simply because I could, and loading microcode at some point would probably be a good idea :meme:

@ElectrodeYT
Copy link
Member Author

One nitpick: amd-ucode is the only package not prefixed with linux-firmware. Is there a particular reason for this?

Convention; most distributions do this, probably because the intel equivalent (which is not made with linux-firmware) is called intel-ucode

@Dennisbonke
Copy link
Member

Dennisbonke commented Aug 20, 2023

Legality question, can we redistribute this as a binary package? Or would that pose issues? @ArsenArsen @avdgrinten. This in connection to xbbs obviously.

@ElectrodeYT ElectrodeYT force-pushed the add-linux-firmware-packages-1 branch from 418da5f to 619a197 Compare August 20, 2023 18:34
@ElectrodeYT
Copy link
Member Author

Legality question, can we redistribute this as a binary package? Or would that pose issues? @ArsenArsen @avdgrinten

As far as I know, it is presumed that all (or at least most) files in linux-firmware are at least redistributable.
The files I picked out with the packages are all redistributable.

@ArsenArsen
Copy link
Member

some of them, see https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-kernel/linux-firmware/linux-firmware-20230804.ebuild (specifically, stuff affected by the bindist and redistributable flags).

@ElectrodeYT
Copy link
Member Author

Bump here again, an intel-lil GPU driver would benefit from having the GuC and HuC firmware blobs, which we would need to supply. Loading CPU microcode would also be interesting to do at some point.

As mentioned before, all packages created here only contain firmware files which are redistributable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants