Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm-util: add option for remote target ip with gdb #261

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

no92
Copy link
Member

@no92 no92 commented Oct 2, 2023

No description provided.

@ArsenArsen
Copy link
Member

why not just replace the whole remote string instead? that way, the port and protocol are also controllable

@no92
Copy link
Member Author

no92 commented Oct 2, 2023

The script hardcodes these parameters for qemu anyways, so the use-case for that would be significantly more limited.

Copy link
Member

@Dennisbonke Dennisbonke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dennisbonke Dennisbonke merged commit 8cb93d7 into managarm:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants