core/exec: Correctly pop loops when CONTINUE_OP is called #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the example code from the issue into the regression tests in lai_tools? |
One moment, I just saw with my own test that my fix is flawed :meme: |
This fixes an issue where a Continue would not pop the actual loop itself, which would manifest in weird execution flow. Fixes managarm#141
ElectrodeYT
force-pushed
the
fix-continue-1
branch
from
454e659 to
604042e
Compare
|
lai_tools#19 is the PR for the test case for this. |
qookei
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a Continue would not pop the actual loop itself, which would manifest in weird execution flow.
Fixes #141