treewide: make public headers compile with c89/c99/c11 pedantic errors #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64
force-pushed
the
c89-headers
branch
15 times, most recently
from
2040f47 to
f06c114
Compare
64
commented
Oct 18, 2024
64
changed the title
64
force-pushed
the
c89-headers
branch
3 times, most recently
from
9046429 to
4f1a0c3
Compare
64
changed the title
64
force-pushed
the
c89-headers
branch
9 times, most recently
from
c6fcba3 to
1e1fd04
Compare
|
The ABI check is complaining about a removed internal union member, this is not an ABI break though. |
Geertiebear
reviewed
Oct 24, 2024
avdgrinten
reviewed
Oct 24, 2024
These are defined in libc-compat.h too.
64
force-pushed
the
c89-headers
branch
2 times, most recently
from
25996b4 to
17fd35f
Compare
64
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1150. Useful as a backstop to detect unwanted C99/C11/GNUisms.
Note that we omit the check for
long long, i.e-Wno-long-longas it requires us to change too many things. In practice, compiling with zero errors under C89 does not matter - neither musl nor glibc's headers compile with-std=c89 -Werror -Wsystem-headers.