Implement various syscalls on Linux for systemd #1197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
reviewed
Jan 2, 2025
| @@ -83,6 +83,12 @@ int sys_ioctl(int fd, unsigned long request, void *arg, int *result); | |||
|
|
|||
| [[gnu::weak]] int sys_getifaddrs(struct ifaddrs **); | |||
|
|
|||
| [[gnu::weak]] int sys_sendfile(int outfd, int infd, off_t *offset, size_t count, size_t *out); | |||
There was a problem hiding this comment.
The use of off_t introduces compilation errors, this is missing #include <bits/off_t.h>.
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Dennisbonke
force-pushed
the
lfs-systemd1
branch
from
45fbbdc to
0035c46
Compare
Without this, the compiler can (and will) hoist the inline assembly in potentially broken ways.
All resolution functions now optionally take the version of the symbol to resolve to. Specifying no version means the default is picked (for dlsym etc).
Some compiler optimizations done via builtins can cause the tests to fail (e.g. compiler optimizes out failing call to calloc, and assumes that it succeeds).
Co-authored-by: 48cf <[email protected]>
Rather than requiring each new sysdep to call this manually, we can put it in a `[[gnu::constructor]]`.
This removes an unnecessary dependency on gtest.
Co-authored-by: 48cf <[email protected]>
Co-authored-by: 48cf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the systemd on Linux project.